bug fixes and visual clean up

README.md

@@ -14,17 +14,27 @@ Photos from https://www.pexels.com/ under [CC0 license](https://www.pexels.com/p
 
 Background pattern from http://subtlepatterns.com/, commercial and non-commercial use allowed with attribution.
 
+## Missing functionality
+
+* Cannot manage group members.
+* Editing chat parameters is incomplete and buggy.
+* Cannot send images or other media.
+* No typing indicators.
+* No indicators of chat status (muted, blocked, etc.).
+* Long polling as a wire transport does not work.
+* Browser push notifications are missing.
+* No encryption.
+
 ## Responsive design
 
 ### Desktop
 
 <p align="center">
-  <img src="web-desktop.png" alt="Desktop web: full app" width=540 />
+  <img src="web-desktop.png" alt="Desktop web: full app" width=866 />
 </p>
 
 ### Mobile
 
-<p align="center" nowrap>
-  <img src="web-mobile-contacts.png" alt="Mobile web: contacts" width=401 />
-  <img src="web-mobile-chat.png" alt="Mobile web: chat" width=485 />
+<p align="center">
+  <img src="web-mob-contacts.png" alt="Mobile web: contacts" width=323 /> <img src="web-mob-chat.png" alt="Mobile web: chat" width=323 /> <img src="web-mob-topicinfo.png" alt="Mobile web: topic info" width=323 />
 </p>

css/base.css

@@ -22,11 +22,6 @@ tt {
   font-family: Roboto Mono, monospace;
 }
 
-hr {
-  height: 1px;
-  color: #666;
-}
-
 a {
   color: #2196f3;
   text-decoration: none;
@@ -78,8 +73,8 @@ button {
   cursor: pointer;
   border: 1px solid transparent;
   white-space: nowrap;
-  padding-left: 2em;
-  padding-right: 2em;
+  padding-left: 2rem;
+  padding-right: 2rem;
   border-radius: 2px;
   box-shadow: 0 2px 5px 0 rgba(0, 0, 0, 0.25);
   text-transform: uppercase;
@@ -256,8 +251,10 @@ ul.menu > li.separator:hover {
   position: relative;
   display: flex;
   flex-direction: column;
+  flex-grow: 0.3;
+  flex-shrink: 0.3;
   width: 24rem;
-  min-width: 24rem;
+  min-width: 18rem;
   height: 100%;
 }
 
@@ -271,8 +268,10 @@ ul.menu > li.separator:hover {
 #info-view {
   display: flex;
   flex-direction: column;
+  flex-grow: 0.3;
+  flex-shrink: 0.3;
   width: 24rem;
-  min-width: 24rem;
+  min-width: 18rem;
   height: 100%;
 }
 
@@ -285,6 +284,8 @@ ul.menu > li.separator:hover {
 @media (max-width: 640px) {
   #app-container {
     width: 100%;
+    border-radius: 0;
+    box-shadow: none;
   }
 
   #sidepanel {
@@ -312,6 +313,11 @@ ul.menu > li.separator:hover {
   display: none!important;
 }
 
+/* Quoted div */
+.quoted {
+  padding-left: 1.5rem;
+}
+
 /* BEGIN InPlaceEdit styles */
 .in-place-edit {
   display: inline-block;
@@ -320,12 +326,10 @@ ul.menu > li.separator:hover {
   height: 2.5rem;
   line-height: 1.5;
   margin: 0.25rem 0.125rem;
-  -x-padding: 0 0.125rem;
   width: 100%;
   vertical-align: baseline;
   border-bottom: 1px dashed #ddd;
   cursor: pointer;
-  overflow: hidden;
 }
 
 .in-place-edit.disabled {
@@ -337,6 +341,12 @@ ul.menu > li.separator:hover {
   color: #bbb;
 }
 
+.in-place-edit .content {
+  display: block;
+  white-space: nowrap;
+  text-overflow: ellipsis;
+  overflow: hidden
+}
 /* END of InPlaceEdit styles */
 
 /* END of top-level layout */
@@ -350,8 +360,8 @@ ul.menu > li.separator:hover {
   display: flex;
   align-items: center;
   flex: none;
-  padding: 0.5em;
-  height: 4em;
+  padding: 0.5rem;
+  height: 4rem;
 
   box-shadow: 0 1px 2px gray;
   z-index: 1; /* otherwise the shadow becomes invisible */
@@ -359,7 +369,7 @@ ul.menu > li.separator:hover {
 
 .dialog-buttons {
   display: flex;
-  padding: 0.5em;
+  padding: 0.5rem;
   justify-content: flex-end;
 }
 
@@ -385,7 +395,7 @@ ul.menu > li.separator:hover {
 
 #sidepanel-title {
   margin-right: auto;
-  margin-left: 0.5em;
+  margin-left: 0.5rem;
 }
 
 #self-avatar {
@@ -421,7 +431,7 @@ ul.menu > li.separator:hover {
   overflow: hidden;
 }
 #alert-box.error-alert {
-  padding: 0.5em;
+  padding: 0.5rem;
   background-color: #ffcdd2;
   border-color: #d32f2f;
   color: #b71c1c;
@@ -484,6 +494,7 @@ ul.menu > li.separator:hover {
   width: 3rem;
   min-width: 3rem;
   height: 3rem;
+  min-height: 3rem;
   font-size: 1.8rem;
   overflow: hidden;
   padding: 0;
@@ -503,7 +514,10 @@ ul.menu > li.separator:hover {
 .contact-box .online, .offline {
   display: inline-block;
   width: 0.75rem;
+  min-width: 0.75rem;
   height: 0.75rem;
+  min-height: 0.75rem;
+  flex-shrink: 0;
   border-radius: 50%;
   position: absolute;
   right: 0;
@@ -519,8 +533,8 @@ ul.menu > li.separator:hover {
 
 #add-topic {
   position: absolute;
-  right: 1em;
-  bottom: 1em;
+  right: 1rem;
+  bottom: 1rem;
 }
 
 /* Various forms inside a panel (signup form, new topic form) */
@@ -544,15 +558,21 @@ ul.menu > li.separator:hover {
 
 /* Styling of avatar upload area in the New Account panel */
 .avatar-upload {
-  position: relative;
-  text-align: center;
-  vertical-align: middle;
+  display: flex;
+  flex-direction: column;
   flex-shrink: 0;
   width: 7rem;
-  height: 7rem;
+  height: 9rem;
   margin-left: 0.5rem;
   padding: 0;
-  border-radius: 50%;
+}
+/* Clearfix */
+.avatar-upload:after {
+  content: ".";
+  display: block;
+  height: 0;
+  clear: both;
+  visibility: hidden;
 }
 
 .avatar-upload .blank {
@@ -560,6 +580,7 @@ ul.menu > li.separator:hover {
   vertical-align: middle;
   border: 1px dashed #999;
   font-size: 1rem;
+  flex-shrink: 0;
   width: 7rem;
   height: 7rem;
   overflow: hidden;
@@ -584,18 +605,19 @@ ul.menu > li.separator:hover {
 }
 
 .avatar-upload .inputfile + label.round {
-  display: inline-block;
-  vertical-align: middle;
-  text-align: center;
+  display: flex;
+  align-items: center;
+  justify-content: center;
   cursor: pointer;
   width: 3rem;
   height: 3rem;
-  line-height: 4rem;
+  line-height: 3rem;
   border-radius: 50%;
   box-shadow: 0 1px 4px rgba(0,0,0,0.4);
-  position: absolute;
-  top: 6rem;
-  left: 2rem;
+  margin-left: auto;
+  margin-right: auto;
+  margin-top: -1rem;
+  bottom: 0;
   background-color: #fafafa;
 }
 
@@ -724,7 +746,7 @@ ul.menu > li.separator:hover {
 
 .chat-box li.single {
   margin-top: 0.25rem;
-  margin-bottom: 0.25rem;
+  margin-bottom: 0.75rem;
 }
 
 .chat-box li.first {
@@ -739,7 +761,7 @@ ul.menu > li.separator:hover {
 
 .chat-box li.last {
   margin-top: 0.15rem;
-  margin-bottom: 0.25rem;
+  margin-bottom: 0.75rem;
 }
 
 .chat-box .left .bubble {
@@ -819,7 +841,7 @@ ul.menu > li.separator:hover {
   font-size: 80%;
   color: #777;
   padding-left: 1rem;
-  top: 0.5em;
+  top: 0.5rem;
   float: right;
   white-space: nowrap;
 }
@@ -980,15 +1002,17 @@ ul.tabbar li.active > a:after {
 /* Badge with the number of unread messages */
 .badge {
   display: inline-block;
-  font-size: 0.8rem;
-  font-weight: bold;
+  font-size: 0.75rem;
+  font-weight: bolder;
   background-color: #0097A7;
   color: white;
-  border-radius: 1em;
-  padding: 0.25em;
-  min-width: 1.75em;
+  border-radius: 50%;
+  padding: 0.25rem;
+  min-width: 1.4rem;
   margin-left: 0.5rem;
+  line-height: 1;
   text-align: center;
+  vertical-align: middle;
 }
 
 /* Color of buttons */

index.html

@@ -225,6 +225,8 @@
         return avatar;
       }
     }
+
+
     /* END Lettertile */
 
     /* BEGIN In-place text editor. Shows text with an icon
@@ -269,6 +271,9 @@
           spanText = this.props.placeholder;
           spanClass += " placeholder";
         }
+        if (spanText.length > 16) {
+          spanText = spanText.substring(0, 16) + "...";
+        }
         return (
           this.state.active ?
             <input type={this.props.type || "text"}
@@ -279,8 +284,9 @@
               onBlur={this.handleEditingFinished}
               autoFocus />
             :
-            <span className={spanClass}
-              onClick={this.handleStartEditing}>{spanText}</span>
+            <span className={spanClass} onClick={this.handleStartEditing}>
+              <span className="content">{spanText}</span>
+            </span>
         );
       }
     });
@@ -518,16 +524,12 @@
     var SettingsView = React.createClass({
       getInitialState: function() {
         return {
-          hostName: this.props.serverAddress,
           transport: "def"
         };
       },
       handleSubmit: function(e) {
         e.preventDefault();
-        this.props.onUpdate(this.state.hostName, this.state.transport);
-      },
-      handleHostNameChange: function(name) {
-        this.setState({hostName: name});
+        this.props.onUpdate(null, this.state.transport);
       },
       handleTransportSelected: function(e) {
         this.setState({transport: e.currentTarget.value});
@@ -550,12 +552,8 @@
         });
         return (
           <form id="settings-form" onSubmit={this.handleSubmit}>
-            <p>This form does not do anything yet</p>
-            <HostSelector
-              serverAddress={this.props.serverAddress}
-              onHostNameChange={this.handleHostNameChange} />
-            <p>Wire transport:</p>
-            <ul>
+            <label className="small">Wire transport:</label>
+            <ul className="quoted">
               {transportOptions}
             </ul>
             <div className="dialog-buttons">
@@ -680,7 +678,6 @@
 
               this.props.state === 'settings' ?
               <SettingsView onCancel={this.props.onCancel}
-                serverAddress={this.props.serverAddress}
                 onUpdate={this.props.onConnectionSettings}
                 /> :
 
@@ -729,7 +726,8 @@
     var EditAccountView = React.createClass({
       getInitialState: function() {
         return {
-          updated: false,
+          updatedDesc: false,
+          updatedPasswd: false,
           address: null,
           fullName: undefined,
           avatar: null,
@@ -760,20 +758,21 @@
       },
 
       handleFullNameUpdate: function(fn) {
-        this.setState({updated: true, fullName: fn});
+        this.setState({updatedDesc: true, fullName: fn});
       },
       handlePasswordUpdate: function(pwd) {
-        this.setState({updated: true, password: pwd});
+        this.setState({updatedPasswd: true, password: pwd});
       },
       handleImageChanged: function(img) {
-        this.setState({updated: true, avatar: img});
+        this.setState({updatedDesc: true, avatar: img});
       },
 
       handleSubmit: function(e) {
         e.preventDefault();
-        if (this.state.updated) {
-          this.props.onSubmit(this.state.password,
-            vcard(this.state.fullName, this.state.avatar));
+        if (this.state.updatedDesc || this.state.updatedPasswd) {
+          this.props.onSubmit(
+            this.state.updatedPasswd ? this.state.password : null,
+            this.state.updatedDesc ? vcard(this.state.fullName, this.state.avatar) : null);
         }
       },
 
@@ -797,15 +796,15 @@
                 avatar={this.state.avatar}
                 onImageChanged={this.handleImageChanged} />
             </div>
-            <br />
-            <hr />
-            <br />
             <div>
               <div>Login: <tt>{this.state.login}</tt></div>
               <div>Address: <tt>{this.state.address}</tt></div>
-              <div>Default access mode:</div>
-              <div>&nbsp;&nbsp;Auth: <tt>{this.state.auth}</tt></div>
-              <div>&nbsp;&nbsp;Anon: <tt>{this.state.anon}</tt></div>
+
+              <div><label className="small">Default access mode:</label></div>
+              <div className="quoted">
+                <div>Auth: <tt>{this.state.auth}</tt></div>
+                <div>Anon: <tt>{this.state.anon}</tt></div>
+              </div>
             </div>
             <div className="dialog-buttons">
               <button className="blue" type="submit">Update</button>
@@ -1172,6 +1171,7 @@
     var InfoView = React.createClass({
       getInitialState: function() {
         return {
+          owner: false,
           updated: false,
           address: null,
           fullName: undefined,
@@ -1187,7 +1187,9 @@
 
         topic.onMetaDesc = this.onMetaDesc;
         var defacs = topic.getDefaultAccess() || {};
+        var acs = topic.getAccessMode();
         this.setState({
+          owner: acs && acs.isOwner(),
           fullName: topic.public ? topic.public.fn : undefined,
           avatar: makeImageUrl(topic.public ? topic.public.photo : null),
           private: topic.private,
@@ -1242,6 +1244,7 @@
                   <div><label className="small">Name</label></div>
                   <div><InPlaceEdit
                       placeholder="Group name"
+                      readOnly={!this.state.owner}
                       text={this.state.fullName}
                       onFinished={this.handleFullNameUpdate} /></div>
                   <div><label className="small">Private comment</label></div>
@@ -1254,15 +1257,15 @@
                   avatar={this.state.avatar}
                   onImageChanged={this.handleImageChanged} />
               </div>
-              <hr />
-              <br />
               <div>
                 <div>Address: <tt>{this.state.address}</tt></div>
                 {this.state.auth || this.state.anon ?
                   <div>
-                    <div>Default access mode:</div>
-                    <div>&nbsp;&nbsp;Auth: <tt>{this.state.auth}</tt></div>
-                    <div>&nbsp;&nbsp;Anon: <tt>{this.state.anon}</tt></div>
+                    <div><label className="small">Default access mode:</label></div>
+                    <div className="quoted">
+                      <div>Auth: <tt>{this.state.auth}</tt></div>
+                      <div>Anon: <tt>{this.state.anon}</tt></div>
+                    </div>
                   </div>
                   :
                   null
@@ -1526,13 +1529,11 @@
                   </a>
                   :
                   null}
-                {this.props.displayMobile ?
-                  <div className="avatar-box">
-                    <LetterTile avatar={avatar}
-                      topic={this.state.topic} title={this.state.title} />
-                    <span className="online" />
-                  </div>
-                  : null}
+                <div className="avatar-box">
+                  <LetterTile avatar={avatar}
+                    topic={this.state.topic} title={this.state.title} />
+                  <span className="online" />
+                </div>
                 <div id="topic-title-group">
                   <div id="topic-title" className="panel-title">{this.state.title}</div>
                   <div id="topic-last-seen">{lastSeen}</div>
@@ -1858,8 +1859,9 @@
 
       handleUpdateAccountRequest: function(password, pub, priv) {
         this.handleSidepanelCancel();
-        var me = Tinode.getMeTopic();
-        me.setMeta({desc: {public: pub, private: priv}});
+        if (pub || priv) {
+          Tinode.getMeTopic().setMeta({desc: {public: pub, private: priv}});
+        }
         if (password) {
           Tinode.updateAccountBasic(null, Tinode.getCurrentLogin(), password);
         }
@@ -2066,7 +2068,8 @@
             <MessagesView
               onHideMessagesView={this.handleHideMessagesView}
               displayMobile={this.state.displayMobile}
-              hideSelf={(this.state.displayMobile && this.state.mobilePanel !== 'topic-view')}
+              hideSelf={(this.state.displayMobile &&
+                (this.state.mobilePanel !== 'topic-view' || this.state.showInfoPanel))}
               topic={this.state.topicSelected}
               myUserId={this.state.myUserId}
               serverVersion={this.state.serverVersion}