fix a race condition in handleScrollEvent (#85)

This commit is contained in:
or-else
2021-08-23 15:30:08 -07:00
parent e73a920154
commit f3e54e46b5
10 changed files with 84 additions and 87 deletions
+2 -2
View File
@@ -1,7 +1,7 @@
{ {
"name": "tinode-webapp", "name": "tinode-webapp",
"description": "Tinode messenger for the web", "description": "Tinode messenger for the web",
"version": "0.17.9", "version": "0.17.10-rc1",
"repository": { "repository": {
"type": "git", "type": "git",
"url": "https://github.com/tinode/example-react-js.git" "url": "https://github.com/tinode/example-react-js.git"
@@ -68,7 +68,7 @@
"react": "^17.0.2", "react": "^17.0.2",
"react-dom": "^17.0.2", "react-dom": "^17.0.2",
"react-intl": "^5.20.2", "react-intl": "^5.20.2",
"tinode-sdk": "^0.17.9" "tinode-sdk": "^0.17.10-rc1"
}, },
"devDependencies": { "devDependencies": {
"@babel/core": "^7.14.5", "@babel/core": "^7.14.5",
+1 -1
View File
@@ -1,3 +1,3 @@
// This is a generated file. Don't edit. // This is a generated file. Don't edit.
export const PACKAGE_VERSION = "0.17.9"; export const PACKAGE_VERSION = "0.17.10-rc1";
+12 -16
View File
@@ -365,23 +365,19 @@ class MessagesView extends React.Component {
// Get older messages // Get older messages
handleScrollEvent(event) { handleScrollEvent(event) {
this.setState({scrollPosition: event.target.scrollHeight - event.target.scrollTop}); this.setState({scrollPosition: event.target.scrollHeight - event.target.scrollTop});
if (this.state.fetchingMessages) {
return;
}
if (event.target.scrollTop <= 0) { if (event.target.scrollTop <= 0) {
this.setState((prevState, props) => { const topic = this.props.tinode.getTopic(this.state.topic);
const newState = {}; if (topic && topic.isSubscribed() && topic.msgHasMoreMessages()) {
if (!prevState.fetchingMessages) { this.setState({fetchingMessages: true}, () => {
const topic = this.props.tinode.getTopic(this.state.topic); topic.getMessagesPage(MESSAGES_PAGE)
if (topic && topic.isSubscribed() && topic.msgHasMoreMessages()) { .catch((err) => this.props.onError(err.message, 'err'))
newState.fetchingMessages = true; .finally(() => this.setState({fetchingMessages: false}));
topic.getMessagesPage(MESSAGES_PAGE) });
.then(() => this.setState({fetchingMessages: false})) }
.catch((err) => {
this.setState({fetchingMessages: false});
this.props.onError(err.message, 'err');
});
}
}
return newState;
});
} }
} }
+25 -31
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
+39 -32
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
@@ -1,3 +1,3 @@
// This is a generated file. Don't edit. // This is a generated file. Don't edit.
const PACKAGE_VERSION = "0.17.9"; const PACKAGE_VERSION = "0.17.10-rc1";