fix: normalize jpush aliases

server/push/jpush/push_jpush_test.go

@@ -97,7 +97,7 @@ func TestPreparePayloadsUsesAliasAndNormalizesP2PTopic(t *testing.T) {
 		t.Fatalf("unexpected payload count: %d %#v", len(payloads), uids)
 	}
 	payload := payloads[0]
-	if got := payload.Audience["alias"][0]; got != callee.UserId() {
+	if got := payload.Audience["alias"][0]; got != aliasForUid(callee) {
 		t.Fatalf("unexpected alias: %s", got)
 	}
 	userTopic, _ := types.P2PNameForUser(callee, topic)
@@ -109,6 +109,16 @@ func TestPreparePayloadsUsesAliasAndNormalizesP2PTopic(t *testing.T) {
 	}
 }
 
+func TestAliasForUidUsesJPushSafeCharacters(t *testing.T) {
+	uid := types.ParseUserId("usrd6Ag5opa-ww")
+	if uid.IsZero() {
+		t.Fatal("test user id did not parse")
+	}
+	if got, want := aliasForUid(uid), "usrd6Ag5opa.ww"; got != want {
+		t.Fatalf("unexpected alias: got %s want %s", got, want)
+	}
+}
+
 func TestPreparePayloadsCanUseRegistrationID(t *testing.T) {
 	oldTokens := store.DevicePushTokens
 	uid := types.Uid(42)