fix: invalidate group settings cache on membership changes

server/store/group_message_runtime_test.go

@@ -13,6 +13,7 @@ type testGroupMessageRuntime struct {
 	seqs            map[string]int64
 	shortStates     map[string]bool
 	deletedPrefixes []string
+	deletedObjects  []string
 }
 
 func newTestGroupMessageRuntime() *testGroupMessageRuntime {
@@ -152,7 +153,8 @@ func (r *testGroupMessageRuntime) GetCachedObject(types.TenantID, string, string
 	return false, nil
 }
 
-func (r *testGroupMessageRuntime) DeleteCachedObject(types.TenantID, string, string) error {
+func (r *testGroupMessageRuntime) DeleteCachedObject(_ types.TenantID, namespace, id string) error {
+	r.deletedObjects = append(r.deletedObjects, namespace+":"+id)
 	return nil
 }
 
@@ -311,3 +313,15 @@ func TestInvalidateGroupMemberPagesUsesTopicKeyPrefix(t *testing.T) {
 		t.Fatalf("unexpected deleted prefixes: %#v", runtime.deletedPrefixes)
 	}
 }
+
+func TestInvalidateGroupSettingsUsesTopicCacheKey(t *testing.T) {
+	oldRuntime := groupMsgRuntime
+	runtime := newTestGroupMessageRuntime()
+	groupMsgRuntime = runtime
+	t.Cleanup(func() { groupMsgRuntime = oldRuntime })
+
+	invalidateGroupSettings(7, " grpAlpha ")
+	if len(runtime.deletedObjects) != 1 || runtime.deletedObjects[0] != "group_settings:grpAlpha" {
+		t.Fatalf("unexpected deleted objects: %#v", runtime.deletedObjects)
+	}
+}

server/store/store.go

@@ -1856,6 +1856,16 @@ func invalidateGroupMemberPages(tenantID types.TenantID, topic string) {
 	}
 }
 
+func invalidateGroupSettings(tenantID types.TenantID, topic string) {
+	topic = strings.TrimSpace(topic)
+	if topic == "" {
+		return
+	}
+	if err := DeleteCachedObject(tenantID, cacheNamespaceGroupSettings, topic); err != nil {
+		logs.Warn.Printf("cache group settings[%s]: delete failed: %v", topic, err)
+	}
+}
+
 func invalidateGroupMemberObjects(tenantID types.TenantID, topic string) {
 	topic = strings.TrimSpace(topic)
 	if topic == "" {
@@ -1923,6 +1933,7 @@ func (groupBusinessMapper) AcceptInvitation(tenantID types.TenantID, invitationI
 	invitation, err := tenantAdp.TenantGroupInvitationAccept(tenantID, strings.TrimSpace(invitationID), uid, memberPrivate, now)
 	if err == nil && invitation != nil {
 		invalidateGroupMemberPages(tenantID, invitation.Topic)
+		invalidateGroupSettings(tenantID, invitation.Topic)
 	}
 	return invitation, err
 }
@@ -1963,6 +1974,7 @@ func (groupBusinessMapper) ResolveJoinRequest(tenantID types.TenantID, topic, re
 	resolved, err := tenantAdp.TenantGroupJoinRequestResolve(tenantID, strings.TrimSpace(topic), strings.TrimSpace(requestID), actor, strings.TrimSpace(action), strings.TrimSpace(rejectReason), version, memberPrivate, now)
 	if err == nil && resolved != nil && resolved.Status == types.GroupJoinRequestStatusAccepted {
 		invalidateGroupMemberPages(tenantID, topic)
+		invalidateGroupSettings(tenantID, topic)
 	}
 	return resolved, err
 }
@@ -2105,8 +2117,9 @@ func (groupBusinessMapper) InviteMember(tenantID types.TenantID, topic string, i
 	}
 	created, err := tenantAdp.TenantGroupInviteMember(tenantID, strings.TrimSpace(topic), inviter, target,
 		strings.TrimSpace(message), strings.TrimSpace(idempotencyKey), private, now)
-	if err == nil {
+	if err == nil && created {
 		invalidateGroupMemberPages(tenantID, topic)
+		invalidateGroupSettings(tenantID, topic)
 	}
 	return created, err
 }
@@ -2126,6 +2139,7 @@ func (groupBusinessMapper) Leave(tenantID types.TenantID, topic string, uid type
 	_ = DeleteCachedObject(tenantID, cacheNamespaceSub, subscriptionCacheID(strings.TrimSpace(topic), uid, false))
 	_ = DeleteCachedObject(tenantID, cacheNamespaceSub, subscriptionCacheID(strings.TrimSpace(topic), uid, true))
 	invalidateGroupMemberPages(tenantID, topic)
+	invalidateGroupSettings(tenantID, topic)
 	return nil
 }
 
@@ -2170,6 +2184,7 @@ func (groupBusinessMapper) TransferOwner(tenantID types.TenantID, topic string,
 	// object so a later Topics.Get sees the new owner.
 	_ = DeleteCachedObject(tenantID, cacheNamespaceTopic, topic)
 	invalidateGroupMemberPages(tenantID, topic)
+	invalidateGroupSettings(tenantID, topic)
 	return nil
 }