fix: reject unrouted messages without seq

server/hub_tenant_test.go

@@ -1,8 +1,10 @@
 package main
 
 import (
+	"net/http"
 	"sync"
 	"testing"
+	"time"
 
 	"github.com/tinode/chat/server/store/types"
 )
@@ -53,3 +55,50 @@ func TestTopicAssignsTenantToServerMessage(t *testing.T) {
 		t.Fatalf("message tenant = %d, want %d", msg.TenantID, topic.tenantID)
 	}
 }
+
+func TestHubRejectsUnroutedClientMessageInsteadOfAcceptingWithoutSeq(t *testing.T) {
+	h := &Hub{
+		topics:     &sync.Map{},
+		routeCli:   make(chan *ClientComMessage, 1),
+		shutdown:   make(chan chan<- bool),
+		routeSrv:   make(chan *ServerComMessage),
+		join:       make(chan *ClientComMessage),
+		meta:       make(chan *ClientComMessage),
+		unreg:      make(chan *topicUnreg),
+		userStatus: make(chan *userStatusReq),
+		rehash:     make(chan bool),
+	}
+	go h.run()
+	done := make(chan bool)
+	defer func() {
+		h.shutdown <- done
+		<-done
+	}()
+
+	sess := &Session{tenantID: 7, send: make(chan any, 1)}
+	now := time.Now().UTC()
+	h.routeCli <- &ClientComMessage{
+		Id:        "pub-1",
+		TenantID:  7,
+		RcptTo:    "p2pMissing",
+		Original:  "p2pMissing",
+		Timestamp: now,
+		sess:      sess,
+	}
+
+	select {
+	case raw := <-sess.send:
+		msg, ok := raw.(*ServerComMessage)
+		if !ok || msg.Ctrl == nil {
+			t.Fatalf("unexpected response: %#v", raw)
+		}
+		if msg.Ctrl.Code != http.StatusConflict || msg.Ctrl.Text != "must attach first" {
+			t.Fatalf("unexpected ctrl: %#v", msg.Ctrl)
+		}
+		if msg.Ctrl.Params != nil {
+			t.Fatalf("unrouted message must not expose seq params: %#v", msg.Ctrl.Params)
+		}
+	case <-time.After(time.Second):
+		t.Fatal("timeout waiting for unrouted message response")
+	}
+}